search

cil-project / cil

C Intermediate Language
Other
360 stars 93 forks source link

Fix native libs install #4

Closed pmundkur closed 11 years ago

pmundkur commented 11 years ago

Native OCaml CIL libs were not getting installed. Configure will now log whether it will install native libs, and the Makefile was fixed to ensure their installation. Also bundled some minor whitespace fixes, and a stylistic fix in cfg.mli.

kerneis commented 11 years ago

Thanks for the patches. They look good, but I don't understand your use case. Plugins are intended to be loaded dynamically, and I thought cmxs were enough in that case. Again, I'm not against merging them in principle, but I'd like a rationale (ideally with a small example that I could include into the documentation or a tutorial on plugin usage).

pmundkur commented 11 years ago

Thanks for your review. My use case is getting CCured (rescued by a colleague probably using the wayback machine) to work against a more recent CIL. It currently builds for the byte code version, the above patch fixes the native build. So one rationale would be that this patch makes it symmetric for byte code and native code builds of CIL applications linking directly against CIL. See

https://github.com/pmundkur/ccured-hack/commit/b3df4f3ded48aa791e5d7c1584de05a1591acff5

kerneis commented 11 years ago

Sounds reasonable. I'll merge this in the next few days.

Thanks again.