search

cilium / cilium-cli

CLI to install, manage & troubleshoot Kubernetes clusters running Cilium
https://cilium.io
Apache License 2.0
417 stars 210 forks source link

Update Test.Fail() and friends to receive context.Context #2042

Open joestringer opened 11 months ago

joestringer commented 11 months ago

Test.failCommon() needs to detect a SIGTERM signal from the user in order to cancel the --pause-on-fail if the user presses ctrl+c:

https://github.com/cilium/cilium-cli/blob/8a38f71407b8b8b47e504d668ca5a74d3dfa6998/connectivity/check/logging.go#L298

Rather than signing up for a new SIGTERM notification inside this function, ideally each test caller should pass the context down into Fail(), Failf(), Fatal(), Fatalf() so that the globally declared SIGTERM handler can trigger the cancel inside failCommon() automatically.

AHB102 commented 10 months ago

@joestringer Is this issue still up for grabs ?

joestringer commented 10 months ago

Yep, feel free to post a PR and link to this issue in the PR.

prashantrewar commented 9 months ago

hey @joestringer, i would like to work on this issue, is this issue still up for grabs ?

joestringer commented 9 months ago

Hi @prashantrewar , I don't see any linked PRs in the breadcrumbs so it should be up for grabs. Next step is to propose a PR and include the Fixes: #2042 tag inside the PR description body.

AHB102 commented 9 months ago

@prashantrewar I had made the necessary changes, but forgot to make a PR, apologies 😔 @joestringer Can you have a look at it, please ?

github-actions[bot] commented 4 days ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.