search

cilium / cilium-cli

CLI to install, manage & troubleshoot Kubernetes clusters running Cilium
https://cilium.io
Apache License 2.0
390 stars 196 forks source link

Sanitize the autodetected cluster name #2591

Closed giorio94 closed 1 week ago

giorio94 commented 3 weeks ago

Replace underscores and dots with dashes, as they are not allowed characters for cluster names.

Additionally perform the same validation already implemented by the latest Cilium version, to exit early and provide a helpful message in case of errors.

Edit. I've removed these changes as bumping the Cilium dependency seems to cause a couple of tests to fail quite consistently.

(The large diff count is caused by bumping the Cilium dependency to the current main, to reuse the already available validation function. Please review commit by commit)

giorio94 commented 2 weeks ago

Let me try dropping the commit which bumps the cilium dependency, to see if the CI failures resolve (as they cannot be possibly caused by the other changes). That also leads to dropping the extra validation, which I'll add back in a separate PR.

giorio94 commented 2 weeks ago

@doniacld Gentle ping :pray:

giorio94 commented 1 week ago

@doniacld Gentle ping 🙏