Add multicast subcommand

yushoyamaguchi commented 1 week ago

Change

This change adds cilium multicast sub command to manage multicast groups and subscribers throughout the cluster

Following commands are added

# show list of multicast group
- cilium multicast list group

# show list of subscribers
- cilium multicast list subscriber --all
- cilium multicast list subscriber --group-ip <group-ip>

# make specified multicast group and add CiliumInternalIP of all cilium nodes to the group in each node
- cilium multicast add --group-ip <group-ip>

# Remove CiliumInternalIP of all cilium nodes from specified multicast group and delete the group in each node
- cilium multicast del --group-ip <group-ip>

This is follow up of https://github.com/cilium/cilium-cli/issues/2574

Display example

cli-result

Additional

As for testing, we will proceed with the implementation of the connectivity test for multicast as described in this issue.(https://github.com/cilium/cilium-cli/issues/2615)

Reference

Current way of setup multicast : https://github.com/cilium/cilium/blob/main/Documentation/network/multicast.rst

yushoyamaguchi commented 1 week ago

@harsimran-pabla Thank you so much for reviewing. I'll fix all points.

I'm sorry, I have two questions. github_err_msg First, these warning messages come from GitHub actions. In other subcommands, variable name cmd is used. Can I ignore these warning messages, or should I change variable name to _ ?

Second, setting resolved tag for the place I fixed is my role or your role? (Currently, I only put 👍) I'm sorry for ignorance about OSS development.

In addition, I replied to some your fix request comments which I cannot find the way to fix. The comment which I put 👍 is the part I fix. I'm glad you to check.

maintainer-s-little-helper[bot] commented 1 week ago

Commit d70128e0f9d7744fb337532ccf1b499b79fd7258 does not match "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

harsimran-pabla commented 5 days ago

Thanks @yushoyamaguchi for addressing these comments.

In other subcommands, variable name cmd is used. Can I ignore these warning messages, or should I change variable name to _ ?

It would be best if you fixed these comments ( these are static syntax checkers and have to make linters happy ).

Second, setting resolved tag for the place I fixed is my role or your role? (Currently, I only put 👍) I'm sorry for ignorance about OSS development.

If you have addressed the comment; feel free to resolve it.

In addition, I replied to some your fix request comments which I cannot find the way to fix.

Please add a comment whichever comment is not clear, I will try my best to explain it further.

harsimran-pabla commented 5 days ago

General commit comment.

Keep each commit about logical change instead of iterations on this PR.
Add more details about the change in the commit description.

yushoyamaguchi commented 3 days ago

@asauber Thank you for your reviewing. I'll fix all improvement point, then tell you.

yushoyamaguchi commented 1 day ago

@harsimran-pabla @asauber

Thank you so much for supporting. I've finished fixing all points.

I'm sorry for making git log complicated, but all commits are grouped by meaning. Only minor changes are put in this commit by force push.

cilium / cilium-cli