search

cilium / cilium-cli

CLI to install, manage & troubleshoot Kubernetes clusters running Cilium
https://cilium.io
Apache License 2.0
390 stars 197 forks source link

Add support for passing annotations to `clustermesh-apiserver` service in the Helm CLI mode #2636

Closed mantoine96 closed 2 days ago

mantoine96 commented 4 days ago

In a previous PR (https://github.com/cilium/cilium-cli/pull/1938), support was added for passing annotations to the clustermesh-apiserver Service definition using the classic CLI.

However the current mode for the CLI, which relies on Helm, lacks this functionality. This PR therefore introduces this feature by relying on the clustermesh.apiserver.service.annotations Helm value and setting it.

I have made sure that passing annotations will also work with the automatic detection of Kubernetes flavor + allow overriding the preset annotations for these flavors.

maintainer-s-little-helper[bot] commented 4 days ago

Commit e662796f2cf64dbe5c49785a0fd26d755f676ceb does not match "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

mantoine96 commented 2 days ago

Thanks for your review @thorn3r! The unintended change has been removed.

mantoine96 commented 2 days ago

Hey! Thanks for the feedback. Totally understand it, although I feel annotations are harmless enough, but I can see the bigger picture.

I'll close this PR then!