cilium / cilium-cli

CLI to install, manage & troubleshoot Kubernetes clusters running Cilium
https://cilium.io
Apache License 2.0
390 stars 197 forks source link

Decompose Cilium sysdump part into fine-grained components #2645

Open marseel opened 4 days ago

marseel commented 4 days ago

Proposal / RFE

Currently we either run all Cilium tasks or we don't run any: https://github.com/cilium/cilium-cli/blob/e04100b9f461d4e6ad58d9a3e2cccd3a3990c8d6/sysdump/sysdump.go#L1390

Ideally, we would split these tasks into groups:

And have similar logic to https://github.com/cilium/cilium-cli/blob/e04100b9f461d4e6ad58d9a3e2cccd3a3990c8d6/sysdump/sysdump.go#L1593-L1601

This would allow us to report a bit more concise output of what was/wasn't detected at the beginning of running sysdump, something like:

Cilium components detected:

And then we wouldn't need to report all information for subtasks (like "Collecting ..." for things that don't exist) and only report ones that failed.