search

cilium / cilium-etcd-operator

Operator to manage Cilium's etcd cluster
Apache License 2.0
26 stars 15 forks source link

cilium-etcd-operator blindly recreates TLS secrets #46

Closed zuzzas closed 5 years ago

zuzzas commented 5 years ago

As per cluster-mesh documentation, we have to provide a formatted secret, which includes all the certs and keys for remote etcd clusters, which form a mesh.

Unfortunately, after cilium-etcd-operator restarts, it blindly recreates etcd TLS secrets, thus invalidating cluster-mesh secrets, which we've carefully formatted and replicated in every meshed cluster.

Is there a reason for this recreation on every cilium-etcd-operator startup? I've failed to find it.

zuzzas commented 5 years ago

I've created a PoC pull request, which solves this issue. Can you take a look, please, @aanm?

zuzzas commented 5 years ago

Seems to be covered in https://github.com/cilium/cilium-etcd-operator/pull/45 already.

aanm commented 5 years ago

@zuzzas this was fixed with #45 which is merged, can we close this issue?

zuzzas commented 5 years ago

Totally. Thank you!