cilium / cilium-service-mesh-beta

Instructions and issue tracking for Service Mesh capabilities of Cilium
Apache License 2.0
104 stars 14 forks source link

cilium-operator skip create CiliumEnvoyConfig CRD when set "enable-envoy-config=true" #25

Closed zhanghe9702 closed 2 years ago

zhanghe9702 commented 2 years ago

Is there an existing issue for this?

What happened?

when start a virtual machine by script vagrant/scripts/start.sh, and configure cilium-agent systemd service start cmdline with enable-envoy-config=true, it will be restart forever!! and print following fatal msg Mar 12 10:32:05 k8s1 cilium-agent[7161]: level=fatal msg="Unable to find all Cilium CRDs necessary within 5m0s timeout. Please ensure that Cilium Operator is running, as it's responsible for registering. it's due to cilium-operator call function AllCRDResourceNames->agentCRDResourceNames to create CRDS, but the later function only add ciliumenvoyconfigs by cilium-agent's config, not cilium-operator!! https://github.com/cilium/cilium/blob/7da6cff33bc502c91c89bf4688deb4db0eb622e8/pkg/k8s/synced/crd.go#L60-L62

    if option.Config.EnableEnvoyConfig {
        result = append(result, CRDResourceName(v2alpha1.CECName))
    }

Cilium Version

vagrant@k8s1:~/go/src/github.com/cilium/cilium$ git log commit d8460a4280ef1a34e441ce673c438897adc63be5 (HEAD -> service_mesh, zhanghe/beta/service-mesh, origin/beta/service-mesh, beta/service-mesh) Author: André Martins andre@cilium.io Date: Thu Dec 9 16:37:33 2021 +0100

.github: add parameter to allow for image suffix

This commits adds a workflow parameter to allow for an
developer-defined image suffix. It's useful if the developers don't want
to use the default "beta" prefix for the docker image repository.

Signed-off-by: André Martins <andre@cilium.io>

Kernel Version

vagrant@k8s1:~/go/src/github.com/cilium/cilium$ uname -a Linux k8s1 4.9.270-0409270-generic #202105261032 SMP Wed May 26 10:36:07 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Kubernetes Version

vagrant@k8s1:~/go/src/github.com/cilium/cilium$ kubectl get nodes -o wide NAME STATUS ROLES AGE VERSION INTERNAL-IP EXTERNAL-IP OS-IMAGE KERNEL-VERSION CONTAINER-RUNTIME k8s1 Ready 2d4h v1.23.0-rc.0 192.168.60.11 Ubuntu 18.04.6 LTS 4.9.270-0409270-generic containerd://1.3.4

Sysdump

No response

Relevant log output

No response

Anything else?

No response

Code of Conduct

zhanghe9702 commented 2 years ago

above description is not correct, it should be other problem!