Closed rio closed 1 year ago
Cc @dylandreimerink
Thank you for the bug report. The label selectors indeed don't seem to like empty lists as evidenced by the values: Invalid value: []string(nil): for 'in', 'notin' operators, values set can't be empty
error message.
However, I agree that this is an edge case that should be handled better given that we proceed to use the nil value after we have concluded it isn't valid. (The fix in this specific location is to add a continue
within the if statement that checks the error, but we should also investigate the rest of the package for similar oversights)
Looking at the code it seems like this bug is also present in v1.12.
Is there an existing issue for this?
What happened?
I attempted to select all nodes for bgp peering by setting the following matchExpression:
The API accepts it but all the cilium-agents immediately started crash looping.
Cilium Version
1.13.0-rc4
Kernel Version
Linux sh 5.15.86-talos #1 SMP Wed Jan 11 12:07:19 UTC 2023 aarch64 Linux
Kubernetes Version
serverVersion: buildDate: "2022-12-08T19:51:45Z" compiler: gc gitCommit: b46a3f887ca979b1a5d14fd39cb1af43e7e5d12d gitTreeState: clean gitVersion: v1.26.0 goVersion: go1.19.4 major: "1" minor: "26" platform: linux/arm64
Sysdump
No response
Relevant log output
Anything else?
No response
Code of Conduct