Prior to 9486e7b731903eb949cb2fcd70f08e1da386dc5d the call to reconcile the node (i.e. nodeUpdated) did not have errors handled. This meant that (*linuxNodeManager).NodeConfigurationChanged(...) would not return an error if there the underlying node reconciliation failed.
This was the assumption prior to v1.15 that node reconciliation tasks log errors in-line and continue exection without returning early. Following these changes, the call to NodeConfigurationChanged will now return an error if the underlying nodeUpdated call fails.
Issue #31843 is a result of the now incorrect dependency on not terminating execution in case of nodeUpdated failure where in cases where (unreachable) node routes for remote nodes failing was previously silently logged - will now cause the agent to terminate on init if this fails. There may be other such regressions built on these expectations.
This reverts to behavior found in v1.14 where this will log nodeUpdated failures and continue execution.
Fixes: #31843
Please ensure your pull request adheres to the following guidelines:
[ ] All code is covered by unit and/or runtime tests where feasible.
[ ] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[ ] If your commit description contains a Fixes: <commit-id> tag, then
please add the commit author[s] as reviewer[s] to this issue.
Prior to 9486e7b731903eb949cb2fcd70f08e1da386dc5d the call to reconcile the node (i.e. nodeUpdated) did not have errors handled. This meant that (*linuxNodeManager).NodeConfigurationChanged(...) would not return an error if there the underlying node reconciliation failed.
This was the assumption prior to v1.15 that node reconciliation tasks log errors in-line and continue exection without returning early. Following these changes, the call to NodeConfigurationChanged will now return an error if the underlying nodeUpdated call fails.
Issue #31843 is a result of the now incorrect dependency on not terminating execution in case of nodeUpdated failure where in cases where (unreachable) node routes for remote nodes failing was previously silently logged - will now cause the agent to terminate on init if this fails. There may be other such regressions built on these expectations.
This reverts to behavior found in v1.14 where this will log nodeUpdated failures and continue execution.
Fixes: #31843
Please ensure your pull request adheres to the following guidelines:
Fixes: #XXX
line if the commit addresses a particular GitHub issue.Fixes: <commit-id>
tag, then please add the commit author[s] as reviewer[s] to this issue.Fixes: #issue-number