search

cilium / design-cfps

Repo to store Cilium CFP design docs
Apache License 2.0
29 stars 25 forks source link

CFP-033: Move cilium/hubble code into cilium/cilium repo #33

Closed michi-covalent closed 5 months ago

chancez commented 5 months ago

Overall, looks good. I think we may want to elaborate slightly more on phase 2, and if there's anything else to be done after that.

For example:

Basically, you outlined the improvements we want to make as part of the goals, but the goals don't actually include the final desired state.

michi-covalent commented 5 months ago

phase 1 in cilium/cilium repo ready for review: https://github.com/cilium/cilium/pull/31893

Do we continue publishing to cilium/hubble forever? Do we start releasing CLI binaries to cilium/cilium at any point?

i was thinking we'll continue using cilium/hubble repo to publish releases and host existing docs.

michi-covalent commented 5 months ago

btw thank you chance for adding these reviewers. i need an approval from a committer before this CFP can be merged.

chancez commented 5 months ago

i was thinking we'll continue using cilium/hubble repo to publish releases and host existing docs.

So forever/indefinitely? Let's make that explicit in the doc.

And what about publishing to cilium/cilium? Is the plan to not publish to c/c, ever?

michi-covalent commented 5 months ago

To make sure I understand: In Phase 1 the Hubble CLI in the Cilium image is built as part of the Cilium release process, and then we manually do a Hubble CLI release to be published at cilium/hubble for download (i.e. all platforms). Phase 2 is about automating the later. Does that sound correct?

yeah that's what i'm thinking. let me make these 2 phases a bit clearer in the CFP.

So forever/indefinitely? Let's make that explicit in the doc.

yeah let me update the docs. btw i'm not against publishing releases in cilium/cilium instead of cilium/hubble at some point. personally i haven't found any strong reasons to make the switch, but i am kind of curious what other sig-hubble folks think 💭

michi-covalent commented 5 months ago

thank you all i updated the CFP based on your feedback. i'll wait until the end of this week before merging the PR in case people have more feedback / questions.