cilium / image-tools

Dockerfiles for cilium-runtime and cilium-builder dependencies
Other
18 stars 29 forks source link

Fix: update readme after new tagging mechanic #294

Closed Artyop closed 3 months ago

Artyop commented 3 months ago

Following the pr #286, update of the README.md about how the tagging mechanic works

Artyop commented 3 months ago

Small nits in the wording, but looks good otherwise, thanks!

thank you, applied the fix !

Artyop commented 3 months ago

Thank you! For future PRs, please squash the two commits together (do keep logical commits in the PR, but review fixes should not stand out as separate commits), and no need to keep the co-authored-by for trivial review fixes 🙂

fixed that too, thanks a lot for the review !

qmonnet commented 3 months ago

I can't merge without the missing reviews. I'll request one from Tobias, as I think Daniel is out.