search

cilium / release

Repository used to generate release notes for Cilium releases
Apache License 2.0
5 stars 5 forks source link

warnings in start-release.sh #214

Open michi-covalent opened 1 month ago

michi-covalent commented 1 month ago 
% ../release/internal/start-release.sh 1.14.11
branch 'pr/prepare-v1.14.11' set up to track 'origin/v1.14'.
Switched to a new branch 'pr/prepare-v1.14.11'
Updating VERSION, AUTHORS.md, helm templates
5ea546af5c8078a26df7fb54c0f1dd90bc365231        refs/heads/v1.14
Checking stable branch v1.12 schema version... grep: warning: stray \ before -
1.25.7
Checking stable branch v1.13 schema version... grep: warning: stray \ before -
1.26.8
Checking stable branch v1.14 schema version... grep: warning: stray \ before -
1.27.1
Checking latest branch schema version... 1.29.8
egrep: warning: egrep is obsolescent; using grep -E
| v1.14              | 1.27.1         |
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
egrep: warning: egrep is obsolescent; using grep -E
joestringer commented 1 week ago

I think this is going to be relying on this file in the target branch to generate the CRD schema docs, so the fix will need to into cilium/cilium and be backported:

https://github.com/cilium/cilium/blob/v1.14/Documentation/check-crd-compat-table.sh

joestringer commented 1 week ago

Alternate solutions may include either re-evaluating the need to publish CRD schema versions in this form, or rewriting the tool in Go.