search

cilium / release

Repository used to generate release notes for Cilium releases
Apache License 2.0
6 stars 6 forks source link

Opening a checklist for a prerelease strips the prerelease suffix #231

Open joestringer opened 1 month ago

joestringer commented 1 month ago

I ran:

$ release checklist open --target-version v1.16.0-rc.2 --template .github/ISSUE_TEMPLATE/release_template_patch_new.md

This created #230, except initially it only said v1.16.0 everywhere. The -rc.2 was removed.

The tool should retain the prerelease suffix.

joestringer commented 1 month ago

Part of the problem here is likely that the way that the substitution substitutes versions in is based on looking for patterns like X.Y.Z in the template. The template here is the patch template, not a prerelease template, so the suffix -rc.N or -pre.N is not available for substitution. As such, when opening the checklist, the final template omits the prerelease suffix entirely.