search

cilium / release

Repository used to generate release notes for Cilium releases
Apache License 2.0
6 stars 6 forks source link

Release tool should not include `cilium-cli-exclusive` labelled PRs in changelog for cilium/cilium #272

Open joestringer opened 1 hour ago

joestringer commented 1 hour ago

During #270 preparation, the changelog PR https://github.com/cilium/cilium/pull/35699/commits/04a3a35f0a41809e7d5f89e5bd1ce6873b44da69 included a reference to https://github.com/cilium/cilium/pull/35021 which is labelled as cilium-cli-exclusive, meaning that it has no impact on the cilium release. Therefore it shouldn't be included in the changelog for new cilium/cilium releases.

chancez commented 1 hour ago

Im using the release tool in another repo that's bundling a few different separate "releasable" entities that need their own change logs, so this is relevant to me too. My initial thought is to use an include or exclude filter on a label that determines which entity is being released, but I haven't thought of it too deeply. For example using --label-filter $THE_ENTITY_BEING_RELEASED could work.

joestringer commented 1 hour ago

I like that idea. We could integrate that very easily into the github workflows we use in cilium/cilium for generating the changelog.