search

cilium / release

Repository used to generate release notes for Cilium releases
Apache License 2.0
6 stars 6 forks source link

Fix truncated checklist issue generation #274

Closed joestringer closed 2 weeks ago

joestringer commented 2 weeks ago

Fix a bug where release issue templates would be truncated before posting them to GitHub whenever they included a horizontal separator (---).

While we're at it, add tests for the templating functionality to ensure that the templates are processed correctly to generate issues with all version numbers substituted. Use golden tests for this (generate with make generate-golden). This also required updating the templates to match the version substitutions supported by the checklist open command.

Review commit-by-commit.

Fixes: #256 Fixes: #261

joestringer commented 2 weeks ago

(Swapped test library to testify since was already vendored)