bpf: remove unused fields in msg_k8s

kkourt commented 1 week ago

This was supposed to be a simple cleanup but ended up encountering complexity issues. The second patch improves the complexity of the programs by moving error handling outside of the loops.

The PR ends up improving the complexity overall. See: https://github.com/cilium/tetragon/actions/runs/11903505830?pr=3127.

Some sample numbers from the link above:

file	program	Insns (A)	Insns (B)	Diff
`bpf_execve_event.o`	`event_execve`	39760	25181	-14579 (-36.67%)
`bpf_execve_event_v53.o`	`event_execve`	173713	144552	-29161 (-16.79%)

Loading time is also reduced which is nice.

netlify[bot] commented 1 week ago

Deploy Preview for tetragon ready!

Name	Link
Latest commit	a4e68a89d57892da309b088af94d65bd8684306e
Latest deploy log	https://app.netlify.com/sites/tetragon/deploys/673b16f81e8ea90008c9b007
Deploy Preview	https://deploy-preview-3127--tetragon.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

kkourt commented 6 days ago

@lambdanis I'm re-requesting a review, because I had to do some fixes (see the second patch). CCing @olsajiri for a second pair of eyes.

cilium / tetragon