cilki / gameframe.online

GameFrame is a gaming analytics website created for CS373
http://gameframe.online
Apache License 2.0
5 stars 1 forks source link

As a user, it would be nice if the filters that have no items in them get removed #67

Closed ccmmaa closed 6 years ago

ccmmaa commented 6 years ago

screen shot 2018-04-09 at 4 19 39 pm For example, there are no developers in Angola

cilki commented 6 years ago

While this seems like a good idea, some people may wonder where their favorite country, Angola, is on the filter list. It's more intuitive for the filter to return no results than for the filter to simply not exist. The same goes for platforms and genres.

therealsamf commented 6 years ago

I agree with @cilki, we don't want to be discriminatory towards specific countries and/or platforms, genres, and the like. Also, each filter would require a large request to our database of rapidly changing data. What's empty today may not be empty tomorrow

atrieder commented 6 years ago

I think that we might be able to improve the usability of our website by adding a message to indicate when there are no instances to be displayed for the given filter. That way, the page would at least let the user know that there is nothing to be shown (since a blank page might be interpreted as unintentional otherwise).

atrieder commented 6 years ago

In commit b7e0f740c251fd319e06e3369bb7fb19044fc1c4, a message is now displayed to inform the user that there are no instances to be displayed:

SCRNSHOT

Since the functionality outlined in my previous comment is now implemented, I think that this user story is complete.

mitchellmarshe commented 6 years ago

Estimated Time: 20 min Actual Time: 10 min