search

cilynx / rtl88x2bu

rtl88x2bu driver updated for current kernels.
http://www.wolfteck.com/2018/02/22/wsky_1200mbps_wireless_usb_wifi_adapter/
GNU General Public License v2.0
1.64k stars 318 forks source link

resolve -Werror=misleading-indentation warning for gcc-11. #150

Closed karubabu closed 3 years ago

karubabu commented 3 years ago

When compiling with gcc11, we will be warned by "-Werror=misleading-indentation". This branch is using "EXTRA_CFLAGS + = -Werror" in makefile need to resolve warnings for compilation.

hood commented 3 years ago

Please get this PR merged, as GCC11 is now shipping in Core for Arch Linux users, making builds fail. See https://archlinux.org/packages/core/x86_64/gcc/.

MaxG87 commented 3 years ago

How does this PR relate to #153 ? They modify the same location but seem to be in conflict with each other. I tend to go with #150 because it does not change anything, it just reindents.

MaxG87 commented 3 years ago

Using -Werror turns out to be a bad idea. Commit ded19c802d5817887ad7fea6fc99e720f4074f6e disables that. I would still like to apply #150 or #153 once it was decided which version is correct.

cilynx commented 3 years ago

It's hard to be sure, but I think #153 is correct and that's the assumption I made on earlier patches -- that the upstream developers indented correctly but forgot the brackets, as opposed to having the brackets correct but messing up blocks of indents.

MaxG87 commented 3 years ago

This sounds very reasonable! I will use this assumption to fix the compilation warnings for Kernel 5.14.Am 04.09.2021 21:38 schrieb "Randy C. Will" @.***>: It's hard to be sure, but I think #153 is correct and that's the assumption I made on earlier patches -- that the upstream developers indented correctly but forgot the brackets, as opposed to having the brackets correct but messing up blocks of indents.

—You are receiving this because you commented.Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.

MaxG87 commented 3 years ago

I used #153 for the reasons @cilynx gave above. Thank you for your contribution!