cilynx / rtl88x2bu

rtl88x2bu driver updated for current kernels.
http://www.wolfteck.com/2018/02/22/wsky_1200mbps_wireless_usb_wifi_adapter/
GNU General Public License v2.0
1.61k stars 316 forks source link

Issues during kernel update 6.5.0-19 -> 6.5..0-21 in Ubuntu 23.10 #264

Open siralexeyduke opened 4 months ago

siralexeyduke commented 4 months ago

Hi! After Kernel update 6.5.0-19 -> 6.5..0-21 the rtl88x2bu/5.8.7.1 can not be built. The make.log has following error messages:

/usr/src/rtl88x2bu-5.8.7.1/os_dep/linux/ioctl_cfg80211.c: In function ‘rtw_cfg80211_ch_switch_notify’:
/usr/src/rtl88x2bu-5.8.7.1/os_dep/linux/ioctl_cfg80211.c:441:17: error: too few arguments to function ‘cfg80211_ch_switch_started_notify’
  441 |                 cfg80211_ch_switch_started_notify(adapter->pnetdev, &chdef, 0, 0, false);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/src/rtl88x2bu-5.8.7.1/include/osdep_service_linux.h:94,
                 from /usr/src/rtl88x2bu-5.8.7.1/include/osdep_service.h:53,
                 from /usr/src/rtl88x2bu-5.8.7.1/include/drv_types.h:27,
                 from /usr/src/rtl88x2bu-5.8.7.1/os_dep/linux/ioctl_cfg80211.c:17:
./include/net/cfg80211.h:8594:6: note: declared here
 8594 | void cfg80211_ch_switch_started_notify(struct net_device *dev,
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/src/rtl88x2bu-5.8.7.1/os_dep/linux/ioctl_cfg80211.c:455:9: error: too few arguments to function ‘cfg80211_ch_switch_notify’
  455 |         cfg80211_ch_switch_notify(adapter->pnetdev, &chdef, 0);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~
  CC [M]  /var/lib/dkms/rtl88x2bu/5.8.7.1/build/hal/led/hal_usb_led.o
./include/net/cfg80211.h:8577:6: note: declared here
 8577 | void cfg80211_ch_switch_notify(struct net_device *dev,
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~

It looks like the cfg80211 API were slightly changed and these functions expect an extra argument - u16 punct_bitmap - preamble puncturing map (see https://elixir.bootlin.com/linux/latest/source/include/net/cfg80211.h#L8660).

MaxG87 commented 3 months ago

This looks a bit like something that was fixed quite a while ago. Can you please confirm you are using the latest version of the driver? Preferably with Git revision hash as reported by git rev-parse HEAD.