search

cimbalino / Cimbalino-Phone-Toolkit

Cimbalino Windows Phone Toolkit
MIT License
78 stars 32 forks source link

Added more converters, extra LockScreen methods and a behaviour #20

Closed ScottIsAFool closed 6 years ago

ScottIsAFool commented 11 years ago

Added three new converters: EnumToBooleanBaseConverter GreaterThanVisibilityConverter LessThanVisibilityConverter

Added two extra methods to the Lock Screen Service that allows you to set the default lock screen and set the lock screen providing a url, if it's an http url it will download the image and save it in isolated storage.

Added SystemTrayProgressIndicatorBehaviour This behaviour lets you have your own colour as the progress indicator in the system tray, rather than the phone's accent colour. Demo of it in use: http://youtu.be/KhmcqDlfZSM

pedrolamas commented 11 years ago

I like the lock screen service changes and I'll definitely will pull them in! :) As for the SystemTrayProgressIndicatorBehavior, I still can't see any usefulness compared with the SystemTrayService (which has a global scope instead of being local as a Behavior); normally theme is set with Styles and you can set one to the PhoneApplicationPage that will control SystemTray colors. The converters are a bit specific but I think they can be made quite useful with a different approach: I keep the "parameter" on the IValueConverter usage to a minimum and instead, create multiple instances of a converter with a property instead, and this seems to me a more clean approach -or- creating a MultiConverter for this case does seem to make more sense...

pedrolamas commented 6 years ago

The Cimbalino Windows Phone Toolkit is now legacy code (replaced by the Cimbalino Toolkit), so I'm now closing all issues & pull requests and will archive this repository.