Import pipe and tibbles from dplyr

[ghost]

Code clarity would be improved with pipes and explicitly importing tibbles would remove the tidygraph::as_tibble workaround in grab_network.R:109.

Also, using tibble directly would make sure hrefs are strings and not factors. Currently, as_tibble is wrapped around data.frame so all the strings get converted to factors.

[cimentadaj]

Thanks @ChuckFinley ! Unfortunately, I'm not gonna give any further maintenance to this package as I'm moving the two functions to the scholar package. See here. As per your issues, I don't want to add the pipe because it's a little bit harder to debug code with pipes + adding more dependencies such as tibble or dplyr. Anyways, if you're interested in continuing contributing, open an issue in the scholar repo and ask whether they're open to changes.

Thanks for the interest!

[ghost]

Sounds good!

On Mon, Jun 25, 2018 at 1:41 AM, Jorge Cimentada notifications@github.com wrote:

Thanks @ChuckFinley https://github.com/ChuckFinley ! Unfortunately, I'm not gonna give any further maintenance to this package as I'm moving the two functions to the scholar package. See here https://github.com/jkeirstead/scholar/pull/54. As per your issues, I don't want to add the pipe because it's a little bit harder to debug code with pipes + adding more dependencies such as tibble or dplyr. Anyways, if you're interested in continuing contributing, open an issue in the scholar repo and ask whether they're open to changes.

Thanks for the interest!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cimentadaj/coauthornetwork/issues/3#issuecomment-399876740, or mute the thread https://github.com/notifications/unsubscribe-auth/AAiRJ1Y1rEOiLpQz5psz47ADqnduFoW7ks5uAKIkgaJpZM4U0inB .