search

cinar / indicatorts

IndicatorTS - Stock technical indicators and strategies in TypeScript for browser and server programs.
MIT License
284 stars 48 forks source link

Fix #405 - Dedicated output directories for ESM and CJS builds. #406

Closed cinar closed 8 months ago

cinar commented 8 months ago

Describe Request

As mentioned in the issue #405, the ESM and CJS builds are overwriting each other. This change uses different output directories for both.

Fixed #405

Change Type

Bug fix.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8f14d6a) 64.64% compared to head (392c3a5) 64.64%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #406 +/- ## ======================================= Coverage 64.64% 64.64% ======================================= Files 93 93 Lines 1533 1533 Branches 183 183 ======================================= Hits 991 991 Misses 529 529 Partials 13 13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vesap commented 8 months ago

This worked nicely in vite. Thanks :)

I don't think I have permission to approve, so I'll give two thumbs up instead 👍 👍 :)

cinar commented 8 months ago

That's awesome! Thank you very much again verifying it. I'll merge this and publish a new release with the change, so that you can consume it easily in your project. I'll send you a note once it is done.