search

cinchapi / concourse

Distributed database warehouse for transactions, search and analytics across time.
http://concoursedb.com
Apache License 2.0
315 stars 234 forks source link

feature/CON-265 #394

Open robertcli opened 5 years ago

robertcli commented 5 years ago

Review for Jeff

robertcli commented 5 years ago

Latest commit contains SpotlessApply.

robertcli commented 5 years ago

I reversed the order of the history and undo(changes, key, record) is now undoing results accurately. Also: added <= to while loop.

NORMAL: 1565204100041001 ADD hi AS 5 (INTEGER) IN 1 AT 1565204100041001 NORMAL: 1565204154077001 REMOVE hi AS 5 (INTEGER) IN 1 AT 1565204154077001 NORMAL: 1565204154078000 ADD hi AS bye (STRING) IN 1 AT 1565204154078000 NORMAL: 1565282665359000 ADD hi AS 5 (INTEGER) IN 1 AT 1565282665359000 NORMAL: 1565282665363000 REMOVE hi AS bye (STRING) IN 1 AT 1565282665363000

REVERSE: 1565282665363000 REMOVE hi AS bye (STRING) IN 1 AT 1565282665363000 REVERSE: 1565282665359000 ADD hi AS 5 (INTEGER) IN 1 AT 1565282665359000 REVERSE: 1565204154078000 ADD hi AS bye (STRING) IN 1 AT 1565204154078000 REVERSE: 1565204154077001 REMOVE hi AS 5 (INTEGER) IN 1 AT 1565204154077001 REVERSE: 1565204100041001 ADD hi AS 5 (INTEGER) IN 1 AT 1565204100041001

jtnelson commented 5 years ago

@robertcli you should write some unit tests