search

cincheo / jsweet-quickstart

A template project to start with JSweet Java to TypeScript transpiler.
Apache License 2.0
17 stars 9 forks source link

Workers #9

Closed koeninger closed 3 years ago

lgrignon commented 3 years ago

Hello @koeninger, thanks for contributing! Did you close this PR by mistake?

lgrignon commented 3 years ago

This example seems nice but would be more appropriate in a dedicated repository, don't you think? Maybe that's why this PR was eventually closed ? :)

koeninger commented 3 years ago

Sorry, I made that PR by mistake, which is why I closed it.

While I'm already bothering you, do you happen to know if there's a better source of java typings for the Fetch api? The candy i was using seemed to result in duplicate d.ts definitions, which is why I was running tsc separately.

On Wed, Mar 3, 2021, 7:06 AM Louis Grignon notifications@github.com wrote:

This example seems nice but would be more appropriate in a dedicated repository, don't you think? Maybe that's why this PR was eventually closed ? :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cincheo/jsweet-quickstart/pull/9#issuecomment-789700592, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAYAB5W5LKOOWNGH6SW3N3TBYX3ZANCNFSM4YPKJZHA .

lgrignon commented 3 years ago

Hello. Sorry I didn't answer earlier. Java typings (jsweet-core/es5&6) are fully open source, please feel free to modify it to better match the actual API and file a PR, I will review ASAP and deploy again.