cincheo / jsweet

A Java to JavaScript transpiler.
http://www.jsweet.org
Other
1.46k stars 158 forks source link

Type mapping and @Erased ignored in some cases #492

Closed chfeiler closed 6 years ago

chfeiler commented 6 years ago

Fix for the following issue: Type mapping and @Erased annotation ignored #479 The following has changed:

The @Module annotation still works even if the referenced import is mapped or erased. All test passed on my local machine. Hope this fix does not limit other use cases:)

renaudpawlak commented 6 years ago

I am trying to catch up a bit here. Thanks. Looks simple and not risky to merge. Would you have time to write a unit test on this one before we merge it? There are some similar tests that you can use as a start in the test code base.

chfeiler commented 6 years ago

I added a simple test, that would fail if the issues of #479 were still there. Luckily everything passes:)

renaudpawlak commented 6 years ago

Looks good to me :) Thanks