Not handling valid Java "function" variable name

[rgladwell]

Using the latest JSweet transpiler (2.3.7) getting compilation errors for valid Java a bit like this:

ERROR: identifier expected. 'function' is a reserved word that cannot be used here at itext7/kernel/src/main/java/com/itextpdf/kernel/pdf/function/PdfFunction.java(58)

With the following code:

            for (PdfFunction function : functions)
                array.add(function.getPdfObject());

Workaround: Renaming the variable name resolves this compilation issue.

Note: function is a reserved keyword in JavaScript.

[lgrignon]

Thanks for reporting, it will be fixed.

[rgladwell]

Thanks!

[lgrignon]

@renaudpawlak did you deploy a snapshot version?

[lgrignon]

Okay, just did it. 2.3.8-SNAPSHOT is up to date

[rgladwell]

I'm getting a similar error for this, despite the fact I think you did fix this. When I compile this file using the latest SNAPSHOT:

https://github.com/ink-elements/itext7-js/blob/master/itext7/kernel/src/main/java/com/itextpdf/kernel/pdf/function/PdfFunction.java

With the following error:

ERROR: identifier expected. 'function' is a reserved word that cannot be used here at itext7/kernel/src/main/java/com/itextpdf/kernel/pdf/function/PdfFunction.java(58)
ERROR: identifier expected at itext7/kernel/src/main/java/com/itextpdf/kernel/pdf/function/PdfFunction.java(58)

Not sure why?

[lgrignon]

Hello again @rgladwell 3.0.0-RC4 has been deployed (and maven plugin is up to date) if you want to give it a shot Warning : if you declare jsweet-core as a dependency, groupId is now <groupId>org.jsweet.v3</groupId>

I hope it will work for you 🤞

[rgladwell]

Thanks @lgrignon.

I can't seem to find the 3.0.0-RC4 dependency:

  <dependencies>
    <dependency>
      <groupId>org.jsweet.v3</groupId>
      <artifactId>jsweet-core</artifactId>
      <version>3.0.0-RC4</version>
    </dependency>
  </dependencies>

Which repo/dependency should I be using? Is the transpiler bundled in the core package now?

[lgrignon]

jsweet-transpiler is 3.0.0-RC4 jsweet-core is 6.0.0 (meaning it's es6+ api)

[rgladwell]

Trying:

  <dependencies>
    <dependency>
      <groupId>org.jsweet.v3</groupId>
      <artifactId>jsweet-transpiler</artifactId>
      <version>3.0.0-RC4</version>
    </dependency>
  </dependencies>

But it still won't resolve

[lgrignon]

<dependency>
      <groupId>org.jsweet</groupId>
      <artifactId>jsweet-transpiler</artifactId>
      <version>3.0.0-RC4</version>
    </dependency>

<dependency>
      <groupId>org.jsweet.v3</groupId>
      <artifactId>jsweet-core</artifactId>
      <version>6.0.0</version>
    </dependency>

sorry for the (temporary) inconvenience

[rgladwell]

Thanks, this seemed to fix this issue.

[rgladwell]

Unfortunately, there is a further error:

https://github.com/cincheo/jsweet/issues/624

[lgrignon]

I close this one, we will focus on https://github.com/cincheo/jsweet/issues/624