search

cincheo / jsweet

A Java to JavaScript transpiler.
http://www.jsweet.org
Other
1.45k stars 160 forks source link

Support for string enums (typescript) #606

Closed basti-schneider closed 4 years ago

basti-schneider commented 4 years ago

This pull request enables the support for generating string enums (https://www.typescriptlang.org/docs/handbook/enums.html#string-enums) in typescript.

renaudpawlak commented 4 years ago

Nice work. It will be a great addition for the upcoming version 2.4 :) Thanks.

renaudpawlak commented 4 years ago

Oops. It breaks the build.

renaudpawlak commented 4 years ago

I think we just need to update the core lib because you added an annotation. That's nothing. I will take care of it ASAP.

basti-schneider commented 4 years ago

Oh, I'll have a look at this in the evening.

basti-schneider commented 4 years ago

Ah right I noticed this and only changed it in my repo

renaudpawlak commented 4 years ago

Don't worry, I'll take care of it because it requires deploying a new core-lib version.

basti-schneider commented 4 years ago

Okay thanks for merging :)

renaudpawlak commented 4 years ago

It should work now... but it is the other PR that poses problem :) I'll take a look at it too.