cincheo / jsweet

A Java to JavaScript transpiler.
http://www.jsweet.org
Other
1.46k stars 158 forks source link

bundle option enhancements #61

Closed lgrignon closed 8 years ago

lgrignon commented 8 years ago

While using the bundle options, there are some annoying points which, IMO, could be easily fixed:

or maybe something clearer like:

<bundleIncludeCandies>false</bundleIncludeCandies>

Thanks.

renaudpawlak commented 8 years ago

Note: bundle is a convenience option for programmers (especially for Java programmers who don't want to deal with such issues). It uses browserify under the hood to bundle the sources in a default, but simple way. Since there are existing bundlers out there, this bundle support should remain very basic and simple, so that it is clear that JSweet should not substitute to these tools. In short, yes, using the bundle option should be very intuitive and simple, but no, I don't think that extra configuration such as excluding candies should be supported by JSweet. When wanting specific or performant bundling, users should start doing their own bundlers.

renaudpawlak commented 8 years ago

These points are solved or made irrelevant by the new bundle system of 1.1.0.