search

cincheo / jsweet

A Java to JavaScript transpiler.
http://www.jsweet.org
Other
1.45k stars 160 forks source link

Remove Test.class from codebase #664

Closed arouel closed 3 years ago

arouel commented 3 years ago

The file in src/main/resources/Test.class gets bundled into transpiler JAR file and causes problems with Gradle when reading the Test.class from the jsweet-transpiler.jar. Since, I see no need for this file I decided to remove it to unblock me from using JSweet with a recent Gradle setup.

Additionally, I set the java.version to 11 since the counting changed in Java 9 by not having a 1. prefix anymore in the version number (see https://docs.oracle.com/en/java/javase/11/tools/javac.html).

This change request fixes #663.

lgrignon commented 3 years ago

Thanks for contributing.

Java over 9 version number is java.release property, the line above. Please revert this change in pom. I will merge right after

arouel commented 3 years ago

I reverted the change in the pom.xml as requested. Looking forward for the next release.

lgrignon commented 3 years ago

FYI I just redeployed 3.1.0-SNAPSHOT

lgrignon commented 3 years ago

Thanks for contributing :)