search

cinchrb / cinch

The IRC Bot Building Framework
http://www.rubydoc.info/gems/cinch
MIT License
1k stars 180 forks source link

Remove references to non-implemented Storage module (resubmitted) #135

Closed dyoung522 closed 10 years ago

dyoung522 commented 10 years ago

Remove any and all references to old (non-working, non-implemented) storage engine.

Resubmitted against maint branch

Removed version bump(s)

dominikh commented 10 years ago

53 commits? I didn't ask you to blindly resubmit your branch to be merged into maint, I asked for it to be rebased on maint, instead of master. :)

dominikh commented 10 years ago

Probably easiest workflow: Create a branch from maint, cherry-pick your commit that removes Storage into it, send a PR for that branch to be merged into maint.

dyoung522 commented 10 years ago

I thought it looked odd. I'm new to pull requests and thought it would automatically cherry pick just my commits.