search

cinchrb / cinch

The IRC Bot Building Framework
http://www.rubydoc.info/gems/cinch
MIT License
1k stars 180 forks source link

ignore +R option #158

Closed suu-g closed 10 years ago

suu-g commented 10 years ago

This pullreq makes Cinch ignore +R mode.

When Cinch joins a channel with +R mode, it outputs error messages and continues to run. +R stands for REOP_LIST, so Cinch doesn't have to do something about it (at least right now). I think it should just be ignored.

dominikh commented 10 years ago

Supporting a mode means doing something meaningful with it, such as storing the information provided and making it available to the user. In the case of +R, that'd mean parsing the list, storing it in an appropriate variable and making it available to the user. Just ignoring it does not count as supporting it.

Generally speaking I am not objecting to that level of support (even though +R seems to be an IRCnet specific mode), if someone wants to implement it. Care should be taken, however, not to confuse this +R with the meaning employed by ircu, which is "REGONLY". But since these two interpretations fall into different mode classes (one has an argument, one doesn't), that'd be straightforward.

suu-g commented 10 years ago

Thanks, I think I get your point about what supporting a mode is. This pullreq should be closed.

Well by the way, afaik IRC modes are case-sensitive, and "REGONLY" is +r, not +R. If this is right, making "REGONLY" and "REOP_LIST" different from each other shall be even easier than you've said. Well, I shall think about supporting +R anyway :)

dominikh commented 10 years ago

Yes, IRC modes are case-sensitive, but according to https://www.alien.net.au/irc/chanmodes.html, +R is REGONLY in Bahamut and tr-ircd, but REOP_LIST in IRCNet, while ircu uses +r for REGONLY. I didn't mean to say ircu in my previous comment but Bahamut, sorry.

I'll close this PR while looking forward to a future PR implementing support for REOP_LIST ;)

suu-g commented 10 years ago

Oh, thanks so much, I completely didn't know those kind of implementation diversity exist in IRC servers! Sorry that I couldn't get what you've meant. I should pay attention to it.