search

cinchrb / cinch

The IRC Bot Building Framework
http://www.rubydoc.info/gems/cinch
MIT License
1k stars 180 forks source link

Italic uses wrong color code, which displays as reverse video in some clients #162

Closed paradox460 closed 10 years ago

paradox460 commented 10 years ago

Some clients display reverse video as Italic, while others display it as reverse video. This leads to inconsistency in display, giving some users italic while others get reverse video, which can be hard on the eyes.

This changes the character code for italic to \x1D, or 29, which shows up as italic across most clients

dominikh commented 10 years ago

Is there any reference that documents 29 as italic?

dominikh commented 10 years ago

Considering that weechat uses \x1d for italic, I'll merge this later. A reference would still be nice, though.

paradox460 commented 10 years ago

Textual and mIRC both list it as 1d. Also, semi-empirical testing in irc last night found that some clients do both as italic, but others only do 1d, and accurately render reverse video On Apr 24, 2014 7:41 AM, "Dominik Honnef" notifications@github.com wrote:

Considering that weechat uses \x1d for italic, I'll merge this later. A reference would still be nice, though.

— Reply to this email directly or view it on GitHubhttps://github.com/cinchrb/cinch/pull/162#issuecomment-41280876 .

dominikh commented 10 years ago

Merged as 93d3285, I rebased it onto maint.