cinchrb / cinch

The IRC Bot Building Framework
http://www.rubydoc.info/gems/cinch
MIT License
1k stars 180 forks source link

Non-threaded handler #186

Closed dantmnf closed 7 years ago

dantmnf commented 9 years ago

Sometimes a simple handler (eg. CTCP VERSION handler) doesn't need a separated thread. It may be better if we have an option to do that.

dominikh commented 9 years ago

Is the separate thread hurting?

To give a somewhat more elaborate answer: For Cinch 2.x I don't see it happening. Primarily because Cinch is in maintenance mode, secondarily because I'm not sure how easy it is to add such an option to the current, somewhat flawed, implementation of handlers.

Maybe if there's ever going to be a Cinch 3, which would be bound to be a rewrite, it will be taken into consideration, even though I still think that it's a pointless optimization, considering that other parts of Cinch are more likely to be the bottleneck than spawning another thread.