cinchrb / cinch

The IRC Bot Building Framework
http://www.rubydoc.info/gems/cinch
MIT License
1k stars 180 forks source link

Authname support for more than Freenode and Quakenet #208

Closed elifoster closed 8 years ago

elifoster commented 8 years ago

When a user is not authenticated, their authname value is not nil, as it logically should be. Instead, it is an exclamation point in a string.

elifoster commented 8 years ago

I just looked more into the code, turns out it's just because I'm not using Quakenet for Freenode.

dominikh commented 8 years ago

If #authname returns "!", the server told us that that's the name. What IRC network are you testing this on, and what's the name of an authenticated user on that network?

elifoster commented 8 years ago

I am testing on EsperNet. What do you mean by the second question?

dominikh commented 8 years ago

I cannot reproduce the issue. For unauthenticated users, the authname is nil. For authenticated users, it is set correctly. Both WHOIS and WHO output look at expected

Can you provide a minimal example demonstrating the issue, and include the raw IRC log as printed by Cinch?

elifoster commented 8 years ago

Nevermind, it was a minor issue on my end that I didn't see initially.