search

cinchrb / cinch

The IRC Bot Building Framework
http://www.rubydoc.info/gems/cinch
MIT License
1k stars 180 forks source link

Fix safe_action #213

Closed stevesoltys closed 7 years ago

stevesoltys commented 8 years ago

Prior to this fix, calling safe_action would invoke the Sanitize method in Cinch::Helpers, which isn't accessible without first including Cinch::Helpers. Using sanitize in Cinch::Helpers fixes this issue.

stevesoltys commented 8 years ago

@dominikh, could you review this? My IRC bot uses the safe_action function, and it would help if this PR was merged.

dominikh commented 8 years ago

Hi, sorry for the delay. I'll try to look at the PR this week.

stevesoltys commented 8 years ago

No problem. Thanks!

bougyman commented 7 years ago

This looks completely safe to me. Pun intended.