str#irc_upcase: Symbol is not quoted

cinchrb / cinch

The IRC Bot Building Framework

http://www.rubydoc.info/gems/cinch

MIT License

1k stars 180 forks source link

str#irc_upcase: Symbol is not quoted #82

Closed mseymour closed 11 years ago

mseymour commented 12 years ago

On line 29 of /lib/cinch/rubyext/string.rb, the symbol (:strict-rfc1459) should be quoted to increase compatibility with older (<~1.8.*) Ruby releases.

Newer releases appear to allow dashes in the syntax, however in 1.8 quotes are required to escape them.

dominikh commented 12 years ago

Not a compatibility issue. Ignoring that we don't support 1.8 anyway, it gets parsed "wrong" across all Ruby versions, namely as as method call (-) on :strict with whatever rfc1459 returns. Of course that doesn't make any sense, so yes, we need quoting here.