search

cinder / Cinder-OpenCV

OpenCV CinderBlock
101 stars 95 forks source link

Fix header for glNext, switch to OpenCV 3.0rc1 #13

Closed heisters closed 9 years ago

heisters commented 9 years ago

This was just a quick pass to get OpenCV 3.0rc1 and glNext playing nicely. Not quite ready for master, but might be a good starting point for anyone else that needs these features. Unfortunately, github doesn't allow PRs to a new branch.

The libs are straight from the OpenCV binary download, which is nice. I seem to recall that we used to have to do a custom compile.

TODO:

richardeakin commented 9 years ago

Thanks for this. Just a note that some of this stuff, if you would like to get it merged in would be easier to do as separate PR's, such as the to toOcvRef() to take ChannelRefs instead of Channel. Specifically around this, I think continueing to pass by const& is nice, though perhaps we should add overloads that take the shared_ptr versions for convenience.

Also worth noting that the dev branch has already been updated for glNext.

heisters commented 9 years ago

oh, thought moving towards using shared_ptrs was part of glNext and the removal of implicitly shared objects. If I have time, I'll move the OCV3 stuff to a new PR.