search

cinder / Cinder

Cinder is a community-developed, free and open source library for professional-quality creative coding in C++.
http://libcinder.org
Other
5.28k stars 940 forks source link

submodule configuration issue and Github Pages #1886

Open kxygk opened 6 years ago

kxygk commented 6 years ago

I have a rather strange issue.

I'm using Cinder as a submodule in my projects - but the way Cinder has boost as a submodule doesn't jive with Github Pages. In .gitmodules Cinder has the links in the form "git://github.com/cinder/..." instead of "https://github.com/cinder/..."

When I try to tell Github to generate a github page in my repository I get an error b/c Cinder is a submodule cinder-github-pages-issue You'll notice the path is in to the Cinder submodule itself!

Github Pages demands that all submodules are HTTPS (recursively), otherwise it won't allow the repository to generate a webpage https://help.github.com/articles/page-build-failed-invalid-submodule/

I tried to message Github about it, but there seems to be no work around short of changing the submodule links and maintaining a fork.

So could you guys change the "git" extension to "https"? Or is there a good reason it's not there already?

kxygk commented 6 years ago

I just an email from Github's staff saying

Hi George,

Thanks for reaching out! Hmm, I believe that you are running into this error because that older site may have been built before git:// submodule references were deprecated -- switching it to use https:// instead should clear up this build error for you.

Please let us know if you have any questions about this!

Cheers, Alex

richardeakin commented 6 years ago

We can try, need to do some testing to see if it causes any problems when updating existing clones. The other thing we might just do is remove the boost submodule entirely, and pack what little source we need left from boost. That's the end plan, anyway.

kxygk commented 6 years ago

cool. I guess the webpage can wait :) funny enough, I've been using my system boost in cinder - but yeah, no other workaround for this weird githubpages issue

thanks for taking the time to look at it

kxygk commented 6 years ago

Looking at this issue again - I see that now there is more than just boost in there - and they still use the deprecated "git://" notation. Can you tell me what test I need to do to make this change happen? @richardeakin