cinder / Cinder

Cinder is a community-developed, free and open source library for professional-quality creative coding in C++.
http://libcinder.org
Other
5.27k stars 939 forks source link

Get rid of most warnings when building OSC block #2197

Closed totalgee closed 3 years ago

totalgee commented 3 years ago

I also added asserts (for extra safety/correctness), but if you don't like those they can be removed. We can "probably" assume no one will try to send OSC messages, arguments or blobs that are more than 2GB or 4GB in size, but just in case... (-;

(unrelated) I also fixed a bug in the Rand unit test, where I assume it was intending to only run a performance test in Release builds, but was instead doing it in Debug (which took forever). At least on Windows, DEBUG wasn't defined in the project (although _DEBUG is) -- but the proper test is normally #ifdef NDEBUG if you want optimized (Release) builds. This should work across all platforms.

andrewfb commented 3 years ago

Thanks for these, including the NDEBUG fix.