search

cinder / Cinder

Cinder is a community-developed, free and open source library for professional-quality creative coding in C++.
http://libcinder.org
Other
5.27k stars 939 forks source link

ImGui: fix "stuck" right shift key in InputText on Windows (#2193) #2202

Closed totalgee closed 3 years ago

totalgee commented 3 years ago

The way modifier key state was sent to ImGui seemed flaky (it failed on Windows in the right-shift case because of the issue I describe in #2193); there are already KeyEvent tests that work well to indicate which modifiers are down.

This fixes the issue with InputText (and InputTextMultiline) on Windows, and should also be valid for Mac (even if it doesn't specifically fix an issue there).

totalgee commented 3 years ago

Thanks for merging; very happy to have this in!