search

cinder / Cinder

Cinder is a community-developed, free and open source library for professional-quality creative coding in C++.
http://libcinder.org
Other
5.34k stars 943 forks source link

Dear ImGui docking functionalities #2219

Open AleksandarPav opened 3 years ago

AleksandarPav commented 3 years ago

Hi, Is it maybe planned to include imgui docking functionalities in the future? Those are present in the last couple of imgui versions. Thanks.

richardeakin commented 3 years ago

Docking is still in a separate branch isn't it? Some time ago there was a decision made for cinder's copy of Dear ImGui to remain on some release, and you should update your copy locally. There is a convenience script to make that easir.

I did just notice that the new tables api has been merged in v1.80, which is a really nice addition. Perhaps worth upgrading just for that.

AleksandarPav commented 3 years ago

First, thanks for your answer. Yes, docking is in separate branch. Cinder's copy of Dear ImGui is on 1.77 (1.80 being the latest release). And updating local copy works fine, but lately only for the code from master branch. When I try to use code from docking branch, right after initialization (ImGui::Initialize() in CinderImGui.cpp file), Visual Studio 2019 crashes. image It happens in this file: C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29333\include\xmemory What is weird to me is that I've checked if the functions used in initialization differ for master and docking branch, and they don't. Also, the same thing happens whether docking (and viewports) flags are enabled or not. That's why I asked if maybe it is planned for those functionalities to be included in cinder's copy. Thanks.

richardeakin commented 3 years ago

Does this happen after doing a full clean and rebuild? There are some macros for math types that tend to cause odd runtime errors like this when old .obj files are used with newer sources.