Otherwise, target_link_libraries cannot later be called with PUBLIC/PRIVATE/etc, and you get a cmake error if you try:
CMake Error at samples/_tutorials/Tutorial01_HelloTriangle/CMakeLists.txt:27 (target_link_libraries):
The plain signature for target_link_libraries has already been used with
the target "Tutorial01_HelloTriangle". All uses of target_link_libraries
with a target must be either all-keyword or all-plain.
The uses of the plain signature are here:
* G:/code/cinder/cinder-main/proj/cmake/modules/cinderMakeApp.cmake:136 (target_link_libraries)
Apologies if this is somewhere already in one of the existing PRs / issues found in the nice list on #2189, I needed to make this change for a specific integration of cinder with a different library using cmake and the change is small so thought I would create a separate PR.
Also, I left it as a PUBLIC linkage since the line right above to target_include_directories also uses PUBLIC, one could argue that it should be PRIVATE but then this is creating the end executable, not sure it makes a difference for the ci_make_app() utility function.
Otherwise, target_link_libraries cannot later be called with PUBLIC/PRIVATE/etc, and you get a cmake error if you try:
Apologies if this is somewhere already in one of the existing PRs / issues found in the nice list on #2189, I needed to make this change for a specific integration of cinder with a different library using cmake and the change is small so thought I would create a separate PR.
Also, I left it as a
PUBLIClinkage since the line right above to target_include_directories also usesPUBLIC, one could argue that it should bePRIVATEbut then this is creating the end executable, not sure it makes a difference for theci_make_app()utility function.