(the check if (wideSize == ERROR_NO_UNICODE_TRANSLATION) is incorrect)
The return value from MultiByteToWideChar() is supposed to be 0 on an error, after which you're supposed to call GetLastError() if you want a more detailed error code (one of which can be ERROR_NO_UNICODE_TRANSLATION).
I was convinced there was a bug or some kind of memory corruption in my code, but I think this is likely a long-standing bug in Cinder (maybe never encountered by anyone else...it only throws/crashes when you happen to try to log a string that is exactly 1113 bytes long :wink:).
For the fix, I will just remove that first if check, and throw the error from the current else clause (could explicitly check GetLastError(), but probably not much more benefit here). I will submit a PR.
andrewfb
commented
2 years ago
Whoa, I just spent some time debugging a mysterious intermittent crash in my program... It was crashing when printing to the console...very rarely.
I just figured out that the issue is here:
https://github.com/cinder/Cinder/blob/e83f5bb9c01a63eec20168d02953a0879e5100f7/src/cinder/msw/CinderMsw.cpp#L146-L152
(the check
if (wideSize == ERROR_NO_UNICODE_TRANSLATION)is incorrect)The return value from
MultiByteToWideChar()is supposed to be 0 on an error, after which you're supposed to callGetLastError()if you want a more detailed error code (one of which can beERROR_NO_UNICODE_TRANSLATION).I was convinced there was a bug or some kind of memory corruption in my code, but I think this is likely a long-standing bug in Cinder (maybe never encountered by anyone else...it only throws/crashes when you happen to try to log a string that is exactly 1113 bytes long :wink:).
For the fix, I will just remove that first
ifcheck, and throw the error from the currentelseclause (could explicitly checkGetLastError(), but probably not much more benefit here). I will submit a PR.