[v2.2] - Turbo module (iOS & Android)

cinder92 / react-native-get-music-files

React Native package to get music files from local and sd for iOS and Android

MIT License

130 stars 66 forks source link

[v2.2] - Turbo module (iOS & Android) #108

Closed cinder92 closed 10 months ago

cinder92 commented 11 months ago

[x] Compatible with RN 0.7+
[x] Compatible with iOS & Android
[x] Limit & offset to improve speed
[x] Removed blur and other properties
[x] NO more event handlers
[x] Permission need to be handled by your own
[x] getAll, getAlbums, searchSongs method works for iOs & Android

@Drazail could you help to test? thanks

Tested on

[x] Real iPhone 13 iOs 16.6.1
[x] Android 11 & 13

How to install

https://stackoverflow.com/questions/33181297/npm-install-from-github-pull-request

cinder92 commented 10 months ago

@flarocca @Haggaish @anthonytietjen @krishcdbry when you have time, please help testing :)

adey69 commented 9 months ago

On Android 14, even after granting READ_MEDIA_AUDIO permission, the getAll function returns an error "Permission denied". I can see the permission being allowed in the settings of the phone. Might want to check this out.

dante-cervantes-rocketlab commented 9 months ago

On Android 14, even after granting READ_MEDIA_AUDIO permission, the getAll function returns an error "Permission denied". I can see the permission being allowed in the settings of the phone. Might want to check this out.

hi @adey69, have you tried requesting READ_EXTERNAL_STORAGE instead?

adey69 commented 9 months ago

On Android 14, even after granting READ_MEDIA_AUDIO permission, the getAll function returns an error "Permission denied". I can see the permission being allowed in the settings of the phone. Might want to check this out.

hi @adey69, have you tried requesting READ_EXTERNAL_STORAGE instead?

Hi @dante-cervantes-rocketlab, I did try it first but then changed it to READ_MEDIA_AUDIO. Refer to the following: https://developer.android.com/about/versions/13/behavior-changes-13#granular-media-permissions

dante-cervantes-rocketlab commented 9 months ago

On Android 14, even after granting READ_MEDIA_AUDIO permission, the getAll function returns an error "Permission denied". I can see the permission being allowed in the settings of the phone. Might want to check this out.

hi @adey69, have you tried requesting READ_EXTERNAL_STORAGE instead?

Hi @dante-cervantes-rocketlab, I did try it first but then changed it to READ_MEDIA_AUDIO. Refer to the following: https://developer.android.com/about/versions/13/behavior-changes-13#granular-media-permissions

Can you create a minimal reproduction of the issue and details of the device? last time i updated the code was tested on Android 13, probably i can test on Android 14 in a simulator ...

adey69 commented 9 months ago

On Android 14, even after granting READ_MEDIA_AUDIO permission, the getAll function returns an error "Permission denied". I can see the permission being allowed in the settings of the phone. Might want to check this out.

hi @adey69, have you tried requesting READ_EXTERNAL_STORAGE instead?

Hi @dante-cervantes-rocketlab, I did try it first but then changed it to READ_MEDIA_AUDIO. Refer to the following: https://developer.android.com/about/versions/13/behavior-changes-13#granular-media-permissions

Can you create a minimal reproduction of the issue and details of the device? last time i updated the code was tested on Android 13, probably i can test on Android 14 in a simulator ...

Here you go for the minimal code. It's based on the example provided by the package owner. Device information: Samsung Galaxy S23 Ultra OS: Android 14 https://github.com/adey69/music_player_test

cinder92 commented 9 months ago

hi @adey69 i have pushed an update in the master branch that fixes the issue for android 14, please take a look.

adey69 commented 9 months ago

hi @adey69 i have pushed an update in the master branch that fixes the issue for android 14, please take a look.

Hi @cinder92, working fine now. Thanks for the quick response.