cinder92 / react-native-get-music-files

React Native package to get music files from local and sd for iOS and Android
MIT License
130 stars 64 forks source link

Request to put the cached album art in a separate folder #51

Closed farshed closed 5 years ago

farshed commented 5 years ago

This is not an issue, just a feature request. The cached album art is stored in the open inside storage. It would be a better UX if it was stored inside a folder with a .nomedia file so it wouldn't show up in the gallery or other apps that scan media.

Drazail commented 5 years ago

@eff-society You can pass a custom path to RNAndroidAudioStore. ( Only works on Android)

farshed commented 5 years ago

Thank you for responding so quick @Drazail. I just saw in the docs that RNAndroidStore.getAll() method now returns album covers but at the cost of performance.

Drazail commented 5 years ago

@eff-society

as a side note, the version we are using internally does include sorting and pagination. its testing is almost done, and I will hopefully push these new features into this repo soon ( .nomedia idea is an interesting one as well, will try to add it as an option in the same release). meanwhile you can use delay and batchNumber parameters on RNAndroidAudioStore.getAll ( and listening to events using DeviceEventEmitter )to minimize the performance hit.

DNA-h commented 5 years ago

The problem is android side is that all the images are added to the user's gallery, so cover folder and .nomedia file make sense.