search

cinderblocks / libremetaverse

An fork of the libopenmetaverse library striving for performance improvements and up-to-date compatibility with Second Life and OpenSimulator (such as it is)
BSD 3-Clause "New" or "Revised" License
61 stars 44 forks source link

Client-Side baking is broken #44

Closed RussoTheDev closed 3 years ago

RussoTheDev commented 3 years ago

Hi,

The client-side baking not working at all because conditional brake fills only the first item of the VisualParam array in the instance of AgentSetAppearancePacket : https://github.com/cinderblocks/libremetaverse/blob/a15c3af511c39c7e4bcb44cc4213b3e69f382d8e/LibreMetaverse/AppearanceManager.cs#L2252 This condition leads to null ref exception in the next loop: https://github.com/cinderblocks/libremetaverse/blob/a15c3af511c39c7e4bcb44cc4213b3e69f382d8e/LibreMetaverse/AppearanceManager.cs#L2255-L2259 Also if I switch the comparison to if (vpIndex >= nrParams) break;, the character appears without textures and alpha.

This issue appears on opensim instance but not in SL because LL server supports server-side baking

Madpeterz commented 3 years ago

Testing now prob something I broke :P

Madpeterz commented 3 years ago

can you tell me what grid you test on as I would like to replicate fully. @RussoTheDev

RussoTheDev commented 3 years ago

The latest version of OpenSim (0.9.1.1) launched in standalone mode without any customization. Just download and launch it on localhost to replicate the issue

Madpeterz commented 3 years ago

its still broken but this makes it less broken https://github.com/cinderblocks/libremetaverse/pull/46

currently working on getting a opensim setup

RussoTheDev commented 3 years ago

Great, it solved the problem with white textures but now I have another one... This is how avatar looks when I am connecting using lib: image This is how it looks when connecting via firestorm: image

I am using a little bit customized version of metaverse lib (was forced to remove some stuff to make it run inside unity). Do you think the problem inside lib or maybe somewhere else? Looks like texture alpha was baked as black color

Madpeterz commented 3 years ago

... stuggling to get firestorm to connect to localhost libmeta via my bot was easy :/

RussoTheDev commented 3 years ago

Here is my OpenSim binaries. it configured to 127.0.0.1:9000 https://drive.google.com/file/d/1_v_Om0xD3GUEHVxgvKma8o9tdoyfV4on/view?usp=sharing Just start opensim.exe and add 127.0.0.1:9000 grid in fs to get it work image Credentials - first-last names: Test Test , password Test

Madpeterz commented 3 years ago

the issue is not just you image

working on it now ^+^

Madpeterz commented 3 years ago

also I found my issue when firestorm tried to load the grid it changed the port to 8002

Madpeterz commented 3 years ago

giving up for tonight if you find it let me know :P will try again in the morning

from what I can tell the head tat texture is being set to NULL_KEY and never being set,

RussoTheDev commented 3 years ago

Alright, may I ask you to give me possible direction of investigation? Where to dig?

Madpeterz commented 3 years ago

turns out this issue was because of me stopping a crash when alpha was out of bounds image

pull/46 should now correct to match the image bake and appearance do need some more love thou

RussoTheDev commented 3 years ago

Great job, thank you

cinderblocks commented 3 years ago

PR accepted in 1.6.2