search

cinderblocks / radegast

Lightweight client for connecting to Second Life and OpenSim based virtual worlds
http://radegast.life/
GNU Lesser General Public License v3.0
65 stars 24 forks source link

Fixed login character hash. OpenMetaverse.Utils.MD5 is deprecated. #25

Closed rafak360 closed 1 year ago

rafak360 commented 1 year ago

Since I was not able to log in due to specific characters contained in my password which the deprecated OpenMetaverse.Utils.MD5 function is not able to hash it properly so this pull request fixes it up. By the way I wonder why most local chat messages get capped, I had a look at the Packet and Network source codes and noticed that only UDP sockets were implemented, shouldn't a TCP socket be implemented for chat messages instead?

cinderblocks commented 1 year ago

Prefer that if this is an issue that it be fixed in LibreMetaverse. (2.x is not using deprecated MD5.) Looks like you are making the assumption that UTF8 is the input which I'm not sure is always correct. Would need to do a more thorough sweep through the code to lockdown UTF8 codepage

rafak360 commented 1 year ago

Prefer that if this is an issue that it be fixed in LibreMetaverse. (2.x is not using deprecated MD5.) Looks like you are making the assumption that UTF8 is the input which I'm not sure is always correct. Would need to do a more thorough sweep through the code to lockdown UTF8 codepage

Well I've installed the latest release Radegast 2.40.347.0 and it seems it still deprecated tho, I'm not able to log in, here's a password that will not work with 2.x: &@mç`$03$fad8#~!

That password is accepted by secondlife.com so people are able to sign up using passwords like that, then when they try to log in in Radegast they will be forced to change their password if they wanna use Radegast which I think is not a good idea since Second Life has the biggest community and Radegast should be under its password standards.