Closed steventan0110 closed 3 years ago
Hi,
Sorry I didn't see the question earlier. No I think the data sampling distribution is only updated in update_language_sampler in trainer. Not sure where the code you saw is from but it should probably not be used. Sorry if it's some code I didn't clean up!
Hi Cindy,
I was studying your code for in trainer.py and it seems like that you perform update for RL scorer (the data actor) in both
update_language_sampler
function andtrain_step
function. Initially I thought you only update the RL inupdate_language_sampler()
where you compute the cosine similarity of two gradients, but then I saw this block of code (which seems to only update ave_emb actor, so I wonder if you actually use this block of code?)Thank you for your help and clarification!