cine-io / cineio-broadcast-android

The cine.io Android Broadcast SDK
https://www.cine.io/products/broadcast
MIT License
52 stars 32 forks source link

Test #3

Closed lgorse closed 9 years ago

lgorse commented 9 years ago

Hi guys,

I set up simple get/set methods for camera selection, screen orientation lock and resolution.

1) Looking forward to feedback on the code. 2) The relevant file is CineIoClient. 3) Hope this is what you expected given our email conversation.

trshafer commented 9 years ago

Thanks @lgorse. I'll take a look and bring in this functionality today.

trshafer commented 9 years ago

Hey @lgorse, I don't think this will modify the final output format of the broadcaster. We need to eventually put those values in our encoding config class: https://github.com/cine-io/cineio-broadcast-android/blob/master/cineio-broadcast-android-sdk/src/main/java/io/cine/android/streaming/EncodingConfig.java#L38 . That's what's used by our muxer and camera getter.

trshafer commented 9 years ago

Closed, in favor of #4